FIX remainder parameter for column transformer visual block
#32713
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remainder parameter for column transformer visual block remainder parameter for column transformer visual block
glemaitre
approved these changes
Dec 12, 2025
Member
glemaitre
left a comment
There was a problem hiding this comment.
LGTM. Thanks @DeaMariaLeon I think we can add a an entry in a changelog because it is impacting the end user.
I'm not really sure how we could write a good non-regression tests here.
Member
Author
|
I don't know why the edit: I don't know if I should add the file in the |
Contributor
It's in the wrong folder ;) |
Member
|
Let's put is in compose considering that the bug was for the representation of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
See #32146 (comment)
What does this implement/fix? Explain your changes.
This PR corrects the ColumnTransformer dotted-line. It was wrongly including the regressor, when remainder was "passthrough".
This was wrong:
Corrected:
The changes on
estimator.pyare meant to remove '[ ]' below the regressor.@glemaitre
Any other comments?
I don't know if changelog file is needed.