🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@p4trickweiss
Copy link
Contributor

@p4trickweiss p4trickweiss commented Nov 26, 2025

Description

(closes #3378)

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for docs-securecodebox ready!

Name Link
🔨 Latest commit 7fe69fe
🔍 Latest deploy log https://app.netlify.com/projects/docs-securecodebox/deploys/693a8cc4b2aa7c0008eeb6d3
😎 Deploy Preview https://deploy-preview-3392--docs-securecodebox.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@p4trickweiss p4trickweiss requested a review from J12934 November 26, 2025 09:35
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had a short look over the general structure of the go code looked good to me so far :)

@p4trickweiss can you have a look at the sonar results?

The function length / cyclometic complexity thingies i think aren't too bad, can be ignoried I'd say. Also the function arg one looks ok for me in this case.

But the naming stuff I'd suggest to change as this is a general golang code style thing, also the context on the struct.

Another thing: can you make sure that the golang tests are also executed in the CI?
ideally also with that go staticcheck tool that we are also using for the operator and such.

@github-project-automation github-project-automation bot moved this from Triage to To Review in secureCodeBox Dec 1, 2025
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@p4trickweiss p4trickweiss requested a review from J12934 December 11, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Review

Development

Successfully merging this pull request may close these issues.

Reimplement git-repo-scanner in Go

2 participants