-
Notifications
You must be signed in to change notification settings - Fork 172
Rewrite git-repo-scanner in Go #3392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-securecodebox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
J12934
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only had a short look over the general structure of the go code looked good to me so far :)
@p4trickweiss can you have a look at the sonar results?
The function length / cyclometic complexity thingies i think aren't too bad, can be ignoried I'd say. Also the function arg one looks ok for me in this case.
But the naming stuff I'd suggest to change as this is a general golang code style thing, also the context on the struct.
Another thing: can you make sure that the golang tests are also executed in the CI?
ideally also with that go staticcheck tool that we are also using for the operator and such.
scanners/git-repo-scanner/examples/github-secureCodeBox-scan/scan.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
Signed-off-by: Patrick <patrick.weiss@iteratec.com>
c03bc5b to
7fe69fe
Compare
|


Description
(closes #3378)
Checklist