🌐 AI搜索 & 代理 主页
Skip to content

chore: remove UNOWNED flag #17105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dummdidumm merged 29 commits into from
Nov 6, 2025
+212 −112
Merged

chore: remove UNOWNED flag #17105

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
64f078d
chore: remove unowned check when calling `e.effect_in_unowned_derived`
Rich-Harris Nov 3, 2025
c9d26db
WIP
Rich-Harris Nov 3, 2025
db21188
all non-unit tests passing
Rich-Harris Nov 3, 2025
b5bb6fb
tidy
Rich-Harris Nov 3, 2025
625d289
WIP
Rich-Harris Nov 3, 2025
6700adb
WIP
Rich-Harris Nov 3, 2025
697fba0
WIP
Rich-Harris Nov 3, 2025
6eb4dee
note to self
Rich-Harris Nov 3, 2025
93f277d
fix
Rich-Harris Nov 3, 2025
e1fbee5
fix
Rich-Harris Nov 3, 2025
b61d1b0
hmm maybe not
Rich-Harris Nov 3, 2025
5b42362
Merge branch 'main' into remove-unowned
Rich-Harris Nov 3, 2025
15f9f85
try this
Rich-Harris Nov 4, 2025
67f544e
simplify
Rich-Harris Nov 4, 2025
d1149d6
remove skip_reaction
Rich-Harris Nov 4, 2025
d5c7605
docs
Rich-Harris Nov 4, 2025
0bd13a9
add changeset, in case this results in changed behaviour
Rich-Harris Nov 4, 2025
3197022
Update packages/svelte/src/internal/client/reactivity/effects.js
Rich-Harris Nov 4, 2025
4d5209c
fix #17024
Rich-Harris Nov 4, 2025
b8fc364
fix comment
Rich-Harris Nov 4, 2025
3d4fa95
revert
Rich-Harris Nov 4, 2025
027194a
fix
Rich-Harris Nov 4, 2025
69290af
dry
Rich-Harris Nov 4, 2025
c96eb44
changeset
Rich-Harris Nov 4, 2025
1032b31
fix WAS_MARKED logic
dummdidumm Nov 4, 2025
22435b2
failing test (that uncovered other unrelated bug) + fix
dummdidumm Nov 5, 2025
d55107f
fix: delete from batch_values on updates (#17115)
dummdidumm Nov 5, 2025
df077f3
tidy up
Rich-Harris Nov 5, 2025
66d6d4b
Merge branch 'main' into remove-unowned
Rich-Harris Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP
  • Loading branch information
@Rich-Harris
Rich-Harris committed Nov 3, 2025
commit 6700adb8fdc26b8c20ba7c22d11ca921b8b96630
2 changes: 1 addition & 1 deletion packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ export function get(signal) {
}

// reconnect a disconnected derived to the graph
if (is_updating_effect && (derived.f & CONNECTED) === 0 && derived.deps !== null) {
if (effect_tracking() && (derived.f & CONNECTED) === 0 && derived.deps !== null) {
derived.f |= CONNECTED;

for (const dep of derived.deps) {
Expand Down