Add Octopush notifier transport #870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jan 8, 2021
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
ghost
suggested changes
Jan 8, 2021
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
| "env": { | ||
| "#1": "OCTOPUSH_DSN=octopush://USERLOGIN:APIKEY@default?from=FROM&type=TYPE" | ||
| } | ||
| } No newline at end of file |
ghost
suggested changes
Jan 8, 2021
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
ghost
suggested changes
Jan 8, 2021
ghost
left a comment
There was a problem hiding this comment.
Pull request does not pass validation.
OskarStark
approved these changes
Jan 8, 2021
OskarStark
added a commit
to symfony/symfony
that referenced
this pull request
Jan 14, 2021
…yliot) This PR was merged into the 5.3-dev branch. Discussion ---------- [Notifier] Add Octopush notifier transport | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no | License | MIT | Doc PR | symfony/symfony-docs#14779 <!-- required for new features --> | Recipe PR| symfony/recipes#870 Commits ------- 93dde15 Add Octopush notifier transport
fabpot
approved these changes
Jan 15, 2021
Member
|
@symfony-flex-server review again please |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.