[Validator] Prevent infinite loop in PropertyMetadata #20146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Oct 4, 2016
| if (false === $objectOrClassName) { | ||
| throw new ValidatorException( | ||
| sprintf('Property "%s" does not exist in class "%s"', $this->getName(), $originalClass) | ||
| ); |
c7f8063 to
9f7c2d5
Compare
Member
|
👍 |
Member
|
Thank you @wesleylancel. |
fabpot
added a commit
that referenced
this pull request
Oct 13, 2016
…leylancel) This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20146). Discussion ---------- [Validator] Prevent infinite loop in PropertyMetadata | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets |n/a | License | MIT | Doc PR | n/a This commit fixes a possible infinite loop in PropertyMetadata when the PropertyMetadata class was constructed with an existing property of class and later used (after being serialized and cached) on that same class while that property no longer existing. `get_parent_class` will return false when there is no parent class and `property_existing` will then keeping return false causing the `while` loop to be infinite. Commits ------- c1ae7b6 Prevent infinite loop in PropertyMetadata
This was referenced Oct 27, 2016
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a possible infinite loop in PropertyMetadata when the PropertyMetadata class was constructed with an existing property of class and later used (after being serialized and cached) on that same class while that property no longer existing.
get_parent_classwill return false when there is no parent class andproperty_existingwill then keeping return false causing thewhileloop to be infinite.