[Travis] Do not use legacy mongo ext #24440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef41a21 to
e86dd64
Compare
Member
Author
|
Remaining failure unrelated. |
Member
|
Fixed in #24409 by a group legacy annotation. |
Member
Author
|
@nicolas-grekas But the test should not be marked as legacy, the class itself is not deprecated |
Member
|
Hum indeed... See master where I just removed the group and kept the test class obviously. |
Member
|
Well, we don't have an easy way to make it legacy conditionally (only when tests are running with the old extension). So I would say it is fine for now. |
Member
Author
|
👍 fine for me as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make travis green after #24438