[Console] add support for iterable in output #26847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23349de to
5100071
Compare
nicolas-grekas
approved these changes
Apr 7, 2018
chalasr
approved these changes
Apr 7, 2018
Tobion
added a commit
that referenced
this pull request
Apr 7, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] add support for iterable in output | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | not really | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Very useful if you just want to print something from a generator. Using array requires everything in memory. Lets make use of the new iterable type. Commits ------- 5100071 [Console] add support for iterable in output
chalasr
added a commit
that referenced
this pull request
Apr 9, 2018
…eln (ogizanagi) This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Support iterable in SymfonyStyle::write/writeln | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Relates to #26847. This would enable iterables benefits even when using `SymfonyStyle` output. Commits ------- d66827e [Console] Support iterable in SymfonyStyle::write/writeln
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Console] fix typo in phpdoc | Q | A | ------------- | --- | Branch? | 4.1 (#26847) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7aa4557 [Console] fix typo in phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very useful if you just want to print something from a generator. Using array requires everything in memory. Lets make use of the new iterable type.