[FrameworkBundle] WebTestCase KernelBrowser::getContainer null return type #31202

Simperfit · 2019-04-23T06:12:00Z

Q	A
Branch?	4.4
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Tests pass?	yes
Fixed tickets	#25920
License	MIT
Doc PR

As @stof suggested in the #25920 I started deprecating the behaviour of returning null when the container is non booted / null.

If this is not wanted we should close both the PR and the issue ;).

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

src/Symfony/Bundle/FrameworkBundle/KernelBrowser.php

derrabus · 2019-04-27T09:32:28Z

Wouldn't it make sense to move that deprecation into the kernel? 🤔

Simperfit · 2019-04-29T05:51:56Z

PR Updated.

src/Symfony/Component/HttpKernel/CHANGELOG.md

src/Symfony/Component/HttpKernel/Kernel.php

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

src/Symfony/Bundle/FrameworkBundle/Tests/KernelBrowserTest.php

Simperfit · 2019-04-29T16:43:38Z

There are alot of deprecation with this being deprecated directly in the Kernel, I see 2 way of fixing this:

marking all test as expecting this deprecation ( :( )
Fixing all the test in this PR, but it seems like modify more than 90 test.

WDYT ?

ro0NL · 2019-04-30T07:46:22Z

Fixing all the test in this PR, but it seems like modify more than 90 test.

is there a legit case that relies on a nulled container? We should check before shipping :)

in general i think tests should be fixed yes, unless it tests a behavior that becomes irrelevant in 5.0; then it's a legacy test.

xabbuh · 2019-04-30T11:33:00Z

The deprecations seem to be triggered by the TestContainer that we use which calls the getContainer() method of the Kernel class even after the kernel was shut down when the reset() method is called.

Simperfit · 2019-05-12T06:33:58Z

Status: Needs Review

Simperfit · 2019-05-18T06:35:14Z

Test fixed !

xabbuh

with minor comment

src/Symfony/Component/HttpKernel/CHANGELOG.md

Simperfit · 2019-08-09T11:48:18Z

PR Rebased

… type

nicolas-grekas · 2019-09-27T10:07:26Z

PR rebased, ready.

fabpot · 2019-09-27T10:15:09Z

Thank you @Simperfit.

@stof

…ner null return type (Simperfit) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] WebTestCase KernelBrowser::getContainer null return type | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? | yes  | Tests pass? | yes  | Fixed tickets | #25920  | License | MIT | Doc PR |   As @stof suggested in the #25920 I started deprecating the behaviour of returning null when the container is non booted / null. If this is not wanted we should close both the PR and the issue ;). Commits ------- e169e1a [FrameworkBundle] WebTestCase KernelBrowser::getContainer null return type

…eal one instead (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] Don't reset the test container but the real one instead | Q | A | ------------- | --- | Branch? | 4.4 for features / 3.4 or 4.3 for bug fixes  | Bug fix? | yes/no | New feature? | yes/no  | Deprecations? | yes/no  | Tickets | Fix #...  | License | MIT | Doc PR | - After #31202 and #32056, the tearDown method keeps throwing deprecation notices about "Getting the container from a non-booted kernel". The reason is that resetting the test-container calls `$kernel->getContainer()` while the kernel has been shut down. This fixes it and a few other glitches found meanwhile. Commits ------- 8e16143 [FrameworkBundle] Dont reset the test container but the real one instead

TomasVotruba · 2019-11-23T19:52:23Z

Pretty nasty BC break between 4.3 and 4.4, took me 2 hours to figure out 😫

This is the fix if anyone needs it: https://github.com/Symplify/Symplify/pull/1681/files

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

…s (Tobion) This PR was merged into the 5.0 branch. Discussion ---------- [FrameworkBundle] remove getContainer overwrites in tests | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no  | Deprecations? | no  | Tickets | | Doc PR | Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see #31202 Commits ------- 5ef9390 remove getContainer overwrites in tests

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony/symfony#31202

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

carsonbot added Status: Needs Review FrameworkBundle Deprecation labels Apr 23, 2019

nicolas-grekas reviewed Apr 23, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md Outdated Show resolved Hide resolved

nicolas-grekas added this to the next milestone Apr 23, 2019

Simperfit force-pushed the dx/get-container-should-not-return-null branch 2 times, most recently from 3d11b16 to b7e5040 Compare April 26, 2019 07:47

ro0NL reviewed Apr 26, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md Outdated Show resolved Hide resolved

Simperfit force-pushed the dx/get-container-should-not-return-null branch from b7e5040 to 6e010c3 Compare April 26, 2019 08:09

xabbuh reviewed Apr 27, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/KernelBrowser.php Outdated Show resolved Hide resolved

Simperfit force-pushed the dx/get-container-should-not-return-null branch from 6e010c3 to 4bc8b7a Compare April 29, 2019 05:51

fabpot requested changes Apr 29, 2019

View reviewed changes

src/Symfony/Component/HttpKernel/CHANGELOG.md Outdated Show resolved Hide resolved

src/Symfony/Component/HttpKernel/Kernel.php Outdated Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels Apr 29, 2019

ro0NL reviewed Apr 29, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md Outdated Show resolved Hide resolved

ro0NL reviewed Apr 29, 2019

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Tests/KernelBrowserTest.php Outdated Show resolved Hide resolved

Simperfit force-pushed the dx/get-container-should-not-return-null branch 2 times, most recently from 5e143c1 to 54428ce Compare April 29, 2019 07:46

Simperfit force-pushed the dx/get-container-should-not-return-null branch from d6e58b3 to bd6c8b0 Compare May 12, 2019 06:33

carsonbot added Status: Needs Review and removed Status: Needs Work labels May 12, 2019

Simperfit force-pushed the dx/get-container-should-not-return-null branch 2 times, most recently from a522f61 to 1b67876 Compare May 18, 2019 06:31

carsonbot added the Status: Needs Review label Aug 7, 2019

xabbuh approved these changes Aug 9, 2019

View reviewed changes

src/Symfony/Component/HttpKernel/CHANGELOG.md Show resolved Hide resolved

carsonbot added Status: Reviewed and removed Status: Needs Review labels Aug 9, 2019

Simperfit force-pushed the dx/get-container-should-not-return-null branch 2 times, most recently from 7a2b34e to 50eda4b Compare August 9, 2019 11:48

[FrameworkBundle] WebTestCase KernelBrowser::getContainer null return…

e169e1a

… type

nicolas-grekas force-pushed the dx/get-container-should-not-return-null branch from 50eda4b to e169e1a Compare September 27, 2019 10:06

fabpot approved these changes Sep 27, 2019

View reviewed changes

fabpot mentioned this pull request Sep 27, 2019

[FrameworkBundle] WebTestCase KernelBrowser::getContainer null return t… symfony/symfony-docs#12385

Closed

fabpot merged commit e169e1a into symfony:4.4 Sep 27, 2019

nicolas-grekas mentioned this pull request Oct 23, 2019

[FrameworkBundle] Don't reset the test container but the real one instead #34078

Merged

nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019

This was referenced Nov 12, 2019

Release v4.4.0-BETA1 #34338

Merged

Release v5.0.0-BETA1 #34339

Merged

Tobion added a commit to Tobion/symfony that referenced this pull request Apr 22, 2020

remove getContainer overwrites in tests

7ecac97

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

Tobion mentioned this pull request Apr 22, 2020

[FrameworkBundle] remove getContainer overwrites in tests #36522

Merged

Tobion added a commit to Tobion/symfony that referenced this pull request Apr 22, 2020

remove getContainer overwrites in tests

5ef9390

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Apr 22, 2020

remove getContainer overwrites in tests

be7811a

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony/symfony#31202

symfony-splitter pushed a commit to symfony/security-bundle that referenced this pull request Apr 22, 2020

remove getContainer overwrites in tests

b26fa15

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony/symfony#31202

vjandrea pushed a commit to vjandrea/symfony that referenced this pull request May 3, 2020

remove getContainer overwrites in tests

d8a2c15

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

vjandrea pushed a commit to vjandrea/symfony that referenced this pull request May 3, 2020

remove getContainer overwrites in tests

3805b3a

Since 5.0 the parent implementation throws an exception anyway making the overwrites obsolete, see symfony#31202

Uh oh!

[FrameworkBundle] WebTestCase KernelBrowser::getContainer null return type #31202

[FrameworkBundle] WebTestCase KernelBrowser::getContainer null return type #31202

Uh oh!

Conversation

Simperfit commented Apr 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

derrabus commented Apr 27, 2019

Uh oh!

Simperfit commented Apr 29, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simperfit commented Apr 29, 2019

Uh oh!

ro0NL commented Apr 30, 2019

Uh oh!

xabbuh commented Apr 30, 2019

Uh oh!

Simperfit commented May 12, 2019

Uh oh!

Simperfit commented May 18, 2019

Uh oh!

xabbuh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Simperfit commented Aug 9, 2019

Uh oh!

nicolas-grekas commented Sep 27, 2019

Uh oh!

fabpot commented Sep 27, 2019

Uh oh!

TomasVotruba commented Nov 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Simperfit commented Apr 23, 2019 •

edited

Loading

TomasVotruba commented Nov 23, 2019 •

edited

Loading