Handle CSV DSN in ZookeeperStore #44532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qkdreyer
commented
Dec 9, 2021
| Q | A |
|---|---|
| Branch? | 6.1 for features / 4.4, 5.3, 5.4 or 6.0 for bug fixes |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
| Doc PR |
stof
requested changes
Dec 9, 2021
| } | ||
|
|
||
| return new \Zookeeper($host); | ||
| return new \Zookeeper(implode($hosts, ',')); |
Member
There was a problem hiding this comment.
please use the right signature of implode which has the separator first, instead of the legacy signature that is deprecated in 7.4 and removed in 8.0
Member
|
Thank you @qkdreyer. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.