[BrowserKit] Add toArray to Response
#45515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d1d712 to
ee8fcc3
Compare
|
Hey! I think @alexander-schranz has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
OskarStark
reviewed
Feb 25, 2022
ee8fcc3 to
a63fe22
Compare
rodnaph
reviewed
Feb 26, 2022
Member
|
LGTM, can you please have a look at @rodnaph's comments? |
a63fe22 to
19e2e3a
Compare
nicolas-grekas
approved these changes
Mar 8, 2022
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
👍 on my side, with or without private array $jsonData; (I don't have any data to decide if one is better than the other).
yceruto
approved these changes
Mar 8, 2022
fabpot
approved these changes
Mar 9, 2022
Member
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
toArraymethod to BrowserKit'sResponsesimilar to the one in HttpClient. Is useful when working with json responses.