[FrameworkBundle] Remove obsolete feature detection #51620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc6deb7 to
dc35c9a
Compare
dc35c9a to
f73384a
Compare
derrabus
commented
Sep 10, 2023
|
|
||
| $loader->load('web.php'); | ||
|
|
||
| if (!class_exists(BackedEnumValueResolver::class)) { |
Member
Author
There was a problem hiding this comment.
Added to symfony/http-kernel with #44831 (6.1). FrameworkBundle requires v6.4+
| if (!ContainerBuilder::willBeAvailable('symfony/translation', Translator::class, ['symfony/framework-bundle', 'symfony/form'])) { | ||
| $container->removeDefinition('form.type_extension.upload.validator'); | ||
| } | ||
| if (!method_exists(CachingFactoryDecorator::class, 'reset')) { |
| ->replaceArgument(0, $config['default_uri']); | ||
| } | ||
|
|
||
| if (!class_exists(Psr4DirectoryLoader::class)) { |
Member
Author
There was a problem hiding this comment.
Added to symfony/routing with #47916 (6.2). FrameworkBundle requires v6.4+.
| $container->removeDefinition('validator.expression_language'); | ||
| } | ||
|
|
||
| if (!class_exists(WhenValidator::class)) { |
Member
Author
There was a problem hiding this comment.
Added to symfony/validator with #42593 (6.2). FrameworkBundle requires v6.4+.
| $container->removeDefinition('serializer.encoder.yaml'); | ||
| } | ||
|
|
||
| if (!class_exists(UnwrappingDenormalizer::class) || !$this->isInitializedConfigEnabled('property_access')) { |
|
|
||
| private function registerCacheConfiguration(array $config, ContainerBuilder $container): void | ||
| { | ||
| if (!class_exists(DefaultMarshaller::class)) { |
| ->addTag('cache.taggable', ['pool' => $name]) | ||
| ; | ||
|
|
||
| if (method_exists(TagAwareAdapter::class, 'setLogger')) { |
Member
Author
There was a problem hiding this comment.
Method has been added in #40740 (Symfony 4.4).
| $container->setDefinition($name, $definition); | ||
| } | ||
|
|
||
| if (method_exists(PropertyAccessor::class, 'createCache')) { |
| $this->registerRetryableHttpClient($retryOptions, 'http_client', $container); | ||
| } | ||
|
|
||
| if ($hasUriTemplate = class_exists(UriTemplateHttpClient::class)) { |
Member
Author
There was a problem hiding this comment.
Class was added to symfony/http-client with #49302 (6.3), FrameworkBundle requires 6.3+.
| ->setArguments([$config['name_based_uuid_namespace']]); | ||
| } | ||
|
|
||
| if (!class_exists(UidValueResolver::class)) { |
Member
Author
There was a problem hiding this comment.
Class was added to symfony/http-kernel with #44665 (6.1), FrameworkBundle requires 6.4+
Member
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some feature detection logic from the
FrameworkExtensionclass that I could identify as obsolete.I'll add some comments to the PR to elaborate why I think a piece of code can be removed.