-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Security][SecurityBundle] OIDC discovery #54932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.2". Cheers! Carsonbot |
|
@Spomky You might be interested by this PR |
00bf574 to
c8c5d7a
Compare
|
Hi @vincentchalamon, Please note that I recently released the Web Token suite 4.0 and proposed #57694. |
|
Hi @Spomky, Yep I just saw that and fixed the conflicts on OidcTokenHandler and services declarations. Do you think it's a good thing to inject a JWSLoader and check the token through it, instead of creating multiple objects (checkers, managers, etc.) and checking the token with ClaimCheckerManager? |
853eaf3 to
b379c48
Compare
I am not sure. To me, the way the tokens are loaded and their content depends on the context of their use i.e. the algorithms, the keys and the verified headers/claims should not be centralized. The JWSLoader service will then only be used by one token handler and have no advantages. |
fe1b665 to
8b75d09
Compare
8b75d09 to
afc9b6e
Compare
afc9b6e to
1a9fe5b
Compare
|
any update about this feature? |
Still waiting for a review |
|
It is too late for 7.2 but I'd like this PR to make it into the next development phase, so expect some review from me asap. |
a5253b4 to
7762b2b
Compare
1060bbe to
434cf63
Compare
Spomky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great. Many thanks.
Please refer to 7.3 instead of 7.2 and it's good to me.
434cf63 to
93f369a
Compare
|
Thank you @vincentchalamon. |
This PR was merged into the 7.3 branch. Discussion ---------- [Security] Fix typos in OIDC methods | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | License | MIT Related to recently merged [OIDC discovery](#54932), the DI is configured to call `enableDiscovery` method but it does not exist – but there is `enabledDiscovery`. Let's drop the extra `d`, and the same for `enabledJweSupport` too. Commits ------- 3d6cc19 Fix typos in OIDC methods
This PR was merged into the 7.3 branch. Discussion ---------- [Security] Add OIDC Discovery Feature: symfony/symfony#54932 Commits ------- f9046f9 docs: add OIDC Discovery documentation
This PR introduces OIDC discovery on
oidcandoidc_user_infotoken handlers.TODO
What is OIDC Discovery?
OIDC discovery is a generic endpoint on the OIDC server, which gives any public information such as signature public keys and endpoints URIs (userinfo, token, etc.). An example is available on the API Platform Demo:
https://demo.api-platform.com/oidc/realms/demo/.well-known/openid-configuration.
Using the OIDC discovery simplifies the
oidcsecurity configuration, allowing to just configure the discovery and let Symfony store the configuration and the keyset in cache. For instance, if the userinfo_endpoint or signature keyset change on the OIDC server, no need to update the environment variables in the Symfony application, just clear the corresponding cache and it'll retrieve the configuration and the keyset accordingly on the next request.In the
oidc_user_infosecurity configuration, it does the same logic but only about userinfo_endpoint as this token handler doesn't need the keyset.How Do I Use This New Feature in Symfony?
The current
oidctoken handler configuration requires akeysetoption which may change on the OIDC server. It is configured as following:With the
discoveryoption, Symfony will retrieve thekeysetdirectly from the OIDC discovery URI and store it in a cache:The current
oidc_user_infotoken handler required abase_uricorresponding to the userinfo_endpoint URI on the OIDC server. This URI may change if it's changed on the OIDC server. Introducing the discovery helps to configure it dynamically.The current configuration looks like the following:
With the
discovery, it will look like this: