[Cache] Add support for valkey: / valkeys: schemes
#59869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtarld
approved these changes
Feb 26, 2025
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
2153d49 to
bcd9500
Compare
valkey: / valkeys: schemesvalkey: / valkeys: schemes
stof
reviewed
Feb 26, 2025
7ba1fdf to
90c665c
Compare
stof
reviewed
Feb 26, 2025
|
|
||
| $params += $query + $options + self::$defaultConnectionOptions; | ||
|
|
||
| if (isset($params['redis_sentinel']) && isset($params['sentinel_master'])) { |
Member
There was a problem hiding this comment.
This removes the fact that you cannot use those options together. You know silently ignore redis_sentinel when sentinel_master (or the new sentinel) is set. Doesn't this introduce a potential WTF debugging moment if $query and $options both configure this using different names for instance ?
Member
Author
There was a problem hiding this comment.
I don't think the exception is useful so I still prefer removing it.
I improved the merging logic to account for this case.
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisExtIntegrationTest.php
Outdated
Show resolved
Hide resolved
90c665c to
ed69e13
Compare
Member
Author
|
Comments addressed @stof, thanks for the review. |
ea420d0 to
9ff20c0
Compare
fabpot
approved these changes
Mar 5, 2025
Member
|
Thank you @nicolas-grekas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valkey is getting a lot of traction, so let's support it as a new scheme (I'm not much into renaming everything :) )