-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Security] improve VoteObject adding extraData for give more possibilities to AccessDecicsionStrategy #60085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
290b65e to
8f4be1b
Compare
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a line about the new argument in the upgrade file
src/Symfony/Component/Security/Core/Authorization/Strategy/AccessDecisionStrategyInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/Voter/Vote.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
Outdated
Show resolved
Hide resolved
83eac24 to
b1ff632
Compare
This comment was marked as outdated.
This comment was marked as outdated.
src/Symfony/Component/Security/Core/Authorization/Strategy/AccessDecisionStrategyInterface.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/Strategy/AffirmativeStrategy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/Strategy/ConsensusStrategy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/Strategy/PriorityStrategy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Authorization/Strategy/UnanimousStrategy.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Security/Core/Tests/Authorization/AccessDecisionManagerTest.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
thanks!! |
nicolas-grekas
approved these changes
Sep 23, 2025
fabpot
approved these changes
Sep 24, 2025
| return $accessDecision->isGranted = $this->strategy->decide( | ||
| $this->collectResults($token, $attributes, $object, $accessDecision) | ||
| $this->collectResults($token, $attributes, $object, $accessDecision), | ||
| $accessDecision |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| $accessDecision | |
| $accessDecision, |
…ities to AccessDecicsionStrategy
b513d95 to
bd24f84
Compare
Member
|
Thank you @eltharin. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of #58107 and #59771, add ExtraData in VoteObject and pass it to AccessDecicsionStrategy Object to allow the decision to be refined.
ExtraData can be an array or an object, and AccessDecicsionStrategy can get it to get the final decision.
In 7.2, voter can only respond abstain / allow or deny, but what if we want more choices, per example a ponderable vote ?
With this PR, it allow to put somme data in the new VoteObject as :
we need also a custom strategy to take this score into account :
AccessDecision contains Vote objects and we can read our score from it.