[DependencyInjection] Respect original service class when a proxy is defined #60766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 12, 2025
Member
stof
left a comment
There was a problem hiding this comment.
We should have tests preventing regressions
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
Member
Author
|
@nicolas-grekas Is it the way to go? If yes, I'll finish this PR asap |
5564059 to
d45bd61
Compare
Member
Author
|
I updated the PR
|
d45bd61 to
002d735
Compare
OskarStark
reviewed
Aug 26, 2025
| { | ||
| public function __construct( | ||
| private Foo $foo, | ||
| private string $name = 'my-app', |
Contributor
There was a problem hiding this comment.
Do we need this prop or can we return my-app directly in getName()?
Member
Author
There was a problem hiding this comment.
yes, it's needed. If I hardcode the name, and revert my patch, the test pass.
Member
|
Good catch, thanks @lyrixx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.