🌐 AI搜索 & 代理 主页
Skip to content

[HttpFoundation][HttpKernel][WebProfilerBundle] Add support for the QUERY HTTP method #61173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Aug 16, 2025
Merged

[HttpFoundation][HttpKernel][WebProfilerBundle] Add support for the QUERY HTTP method #61173

fabpot merged 1 commit into from
Aug 16, 2025

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-daubois alexandre-daubois commented Jul 21, 2025 •
edited
Loading

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #60521
License MIT

Not much difference from GET, appart that the request body is used to generate the cache key in HttpCache.

Webprofiler integration:

image

@carsonbot carsonbot added this to the 7.4 milestone Jul 21, 2025
stof
stof requested changes Jul 21, 2025
View reviewed changes
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 21, 2025
Closed
@MatTheCat
Copy link
Contributor

MatTheCat commented Jul 21, 2025

Should

symfony/src/Symfony/Component/HttpFoundation/Request.php

Line 257 in 3ec571d

&& \in_array(strtoupper($request->server->get('REQUEST_METHOD', 'GET')), ['PUT', 'DELETE', 'PATCH'], true)
be updated to add QUERY to the list?

@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jul 21, 2025

The same question applies to create(). I'm not sure. The RFC says:

Implementations MAY use a request body of any content type with the QUERY method

I guess that if we may, we can fallback on application/x-www-form-urlencoded like other methods

@stof
Copy link
Member

stof commented Jul 21, 2025

We should indeed parse a application/x-www-form-urlencoded body like for other methods.

@alexandre-daubois alexandre-daubois force-pushed the query-method branch 4 times, most recently from 0201731 to f9d9416 Compare July 21, 2025 12:03
@carsonbot carsonbot changed the title [HttpFoundation][HttpKernel] Add support for the QUERY HTTP method [HttpFoundation][HttpKernel][WebProfilerBundle] Add support for the QUERY HTTP method Jul 21, 2025
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jul 21, 2025

PR updated. A follow-up PR would be to also support the method in HttpClient. I added support for the method also in WebProfilerBundle

@alexandre-daubois alexandre-daubois force-pushed the query-method branch 5 times, most recently from 759bdfd to c6c62e4 Compare July 21, 2025 13:17
@alexandre-daubois
Copy link
Member Author

alexandre-daubois commented Jul 21, 2025 •
edited
Loading

The tests are passing, but failing when reruned here. Not sure why though. Should we remove http-kernel@^6.4 from WebProfilerBundle's composer.json?

Status: Needs Review

@fabpot
Copy link
Member

fabpot commented Aug 16, 2025

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 73ce8e5 into symfony:7.4 Aug 16, 2025
10 of 12 checks passed
@fabpot fabpot mentioned this pull request Aug 16, 2025
Closed
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 15, 2025
Merged
nicolas-grekas added a commit that referenced this pull request Oct 15, 2025
@nicolas-grekas
feature #62073 [HttpClient] Add QUERY to the list of retriable HTTP m…
e3141c9 
…ethods (nicolas-grekas)

This PR was merged into the 7.4 branch.

Discussion
----------

[HttpClient] Add QUERY to the list of retriable HTTP methods

| Q             | A
| ------------- | ---
| Branch?       | 7.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | #60521
| License       | MIT

Similar to #61173

Commits
-------

da60084 [HttpClient] Add QUERY to the list of retriable HTTP methods
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof requested changes

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

No one assigned

Labels

Feature HttpFoundation HttpKernel Status: Reviewed WebProfilerBundle

Projects

None yet

Milestone

7.4

Development

Successfully merging this pull request may close these issues.

Add support for QUERY method

7 participants

@alexandre-daubois @MatTheCat @stof @fabpot @nicolas-grekas @OskarStark @carsonbot