🌐 AI搜索 & 代理 主页
Skip to content

[Serializer] Adjust ObjectNormalizerTest for the accessor method changes from #61097 #61660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Sep 5, 2025
Merged

[Serializer] Adjust ObjectNormalizerTest for the accessor method changes from #61097 #61660

nicolas-grekas merged 1 commit into from
Sep 5, 2025

Conversation

@RafaelKr
Copy link
Contributor

@RafaelKr RafaelKr commented Sep 5, 2025

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #61096
License MIT

This is a follow-up PR to #61097
CC @nicolas-grekas

@RafaelKr RafaelKr requested a review from dunglas as a code owner September 5, 2025 11:06
@carsonbot carsonbot added this to the 6.4 milestone Sep 5, 2025
@RafaelKr RafaelKr mentioned this pull request Sep 5, 2025
Merged
@RafaelKr RafaelKr force-pushed the tests_61097 branch 3 times, most recently from 9f68453 to cebdb8e Compare September 5, 2025 11:23
@RafaelKr
Copy link
Contributor Author

RafaelKr commented Sep 5, 2025 •
edited
Loading

@nicolas-grekas it's ready for another review. I also created protected function getNormalizerForAccessors($accessorPrefixes = null): ObjectNormalizer, as it's done for some other test groups.

@RafaelKr
Copy link
Contributor Author

RafaelKr commented Sep 5, 2025

Thanks for the approval. Did you see my comment on the // accessors comment? Can we resolve the conversation?

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 5, 2025

Thank you @RafaelKr.

@nicolas-grekas nicolas-grekas merged commit ae0ad41 into symfony:6.4 Sep 5, 2025
9 of 11 checks passed
@RafaelKr RafaelKr deleted the tests_61097 branch September 5, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Serializer Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

3 participants

@RafaelKr @nicolas-grekas @carsonbot