[Mailer][MailJet] Fix forbidden headers case-sensitive comparison #61876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure that forbidden headers are not sent, regardless of their case, e.g. "Sender" and "sender" should both be forbidden.
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
Contributor
Author
|
��\(ツ)/¯ |
stof
requested changes
Sep 29, 2025
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
This follows the PR review.
OskarStark
reviewed
Sep 29, 2025
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
This follows the PR review.
stof
requested changes
Sep 29, 2025
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Transport/MailjetApiTransport.php
Show resolved
Hide resolved
This follows the PR review.
It's preferable to keep the constant with 'TitleCase' for readability, so we make all array keys lowercase prior to looping through the headers. This follows the PR review.
This follows the PR review.
fabpot
approved these changes
Sep 30, 2025
Member
|
Thank you @benjamintoussaint. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2025
…parison (benjamintoussaint) This PR was submitted for the 7.4 branch but it was squashed and merged into the 6.4 branch instead. Discussion ---------- [Mailer][MailJet] Fix forbidden headers case-sensitive comparison | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #44000 | License | MIT We need to ensure that forbidden headers are not sent, regardless of their case, e.g. "Sender" and "sender" should both be forbidden. Commits ------- b1e4576 [Mailer][MailJet] Fix forbidden headers case-sensitive comparison
Member
|
Merged |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure that forbidden headers are not sent, regardless of their case, e.g. "Sender" and "sender" should both be forbidden.