[HttpFoundation] drop support for HTTP method override for GET, HEAD, CONNECT and TRACE requests #62042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 11, 2025
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
commented
Oct 11, 2025
|
|
||
| $method = strtoupper($method); | ||
|
|
||
| if (\in_array($method, ['GET', 'HEAD', 'CONNECT', 'TRACE'], true)) { |
Member
Author
There was a problem hiding this comment.
I wonder if we should forbid (in 7.4) listing any of these methods in $allowedHttpMethodOverride
Member
There was a problem hiding this comment.
And return a 400?
I wondered the same and thought: what for in the end?
Member
Author
There was a problem hiding this comment.
I was thinking of throwing an exception if setAllowedHttpMethodOverride() is called with a list of methods of which one or more are matching this list.
Member
There was a problem hiding this comment.
Ah, yes, that'd work for me, to spot misconfigs earlier
Member
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 14, 2025
…rride of GET, HEAD, CONNECT and TRACE (xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle][HttpFoundation] forbid HTTP method override of GET, HEAD, CONNECT and TRACE | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | see #62042 (comment) | License | MIT Commits ------- 1b79380 forbid HTTP method override of GET, HEAD, CONNECT and TRACE
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.