[Security] revert trying different CSRF tokens in logout listener #62086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you expand on why this shouldn't be the correct fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to revert #62037 as I doubt that the proposed fix is the solution for the problem described. First, we are now always reading data from the request body as mentioned in #62037 (comment).
Then, the issue the PR tries to fix is described as follows:
IMO what this really means is that the shouldn't be a URL with an invalid token being generated in the first place instead of doing guess work in the listener about which one to pick.
I have added a test to prove that the listener is able to properly validate CSRF tokens as part of the request body as well as tokens provided as URL parameters.