[JsonStreamer] Ignore Deprecations in tests #62154
Closed
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Im not in my computer now but I think the failure tests are not relevant in the context of the PR |
Contributor
|
Hey @santysisi, thanks for trying to fix this 🙂 Here, we should not ignore the deprecations, as they're not intended. |
Member
|
I agree, closing in favour of #62158, thanks for giving it a try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rebasing this PR, I noticed deprecation warnings appearing in the tests. After investigation, it seems to be caused by the addition of
trigger_deprecationsof this other PR. To resolve this, I’ve added theGroup('legacy')attribute and also usedIgnoreDeprecationsfor the affected tests to prevent these warnings.