[HttpClient] Fix caching client decorating scoping client #62169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
221dc18 to
5bb8918
Compare
5bb8918 to
aeb55c4
Compare
Member
|
I checked out the code on a test app and figured your initial patch didn't work. I force-pushed a new one. |
6e5a9ee to
bfde962
Compare
Member
|
Thank you @pierredup. |
stof
reviewed
Oct 28, 2025
| $retryOptions = $scopeConfig['retry_failed'] ?? ['enabled' => false]; | ||
| unset($scopeConfig['retry_failed']); | ||
|
|
||
| $transport = $name.'.transport'; |
Member
There was a problem hiding this comment.
instead of introducing this separate service, we could register $name with the initial service (which could even be a DI alias instead of this current() hack in the factory) and then registering ScopingHttpClient as a decorator of that service, allowing to configure the decoration priority even for cases where ScopingHttpClient should not be the outer one (see UriTemplateHttpClient which is still on the outside).
alexandre-daubois
added a commit
that referenced
this pull request
Oct 29, 2025
…olas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] Simplify wiring of scoped clients | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT As advised by `@stof` in #62169 (comment) Commits ------- f04c2a8 [FrameworkBundle] Simplify wiring of scoped clients
This was referenced Nov 2, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering a scoped client and enabling caching, the scoping client should decorate the caching one, while currently it's registered the wrong way around. This causes
Invalid URLexceptions, since the URL is not resolved first by the scoping client