[DomCrawler] Properly ignore errors when using the native HTML5 parser #62180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Oct 27, 2025
| use Symfony\Component\DomCrawler\Link; | ||
|
|
||
| class CrawlerTestCase extends TestCase | ||
| class CrawlerTest extends TestCase |
Member
There was a problem hiding this comment.
should this really be a test on its own rather than a testcase extended by bother various tests ?
Member
Author
There was a problem hiding this comment.
yep, that's how PHP 8.5 is tested (should be)
e2fb1b2 to
0362d51
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Oct 28, 2025
…las-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [DomCrawler] Fix converting HTML5 trees to DOM nodes | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62176 | License | MIT Much better than #62180 Commits ------- 6426ae0 [DomCrawler] Fix converting HTML5 trees to DOM nodes
This was referenced Nov 2, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @stof in #62176