🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@webflo
Copy link
Contributor

@webflo webflo commented Oct 29, 2025

Q A
Branch? 7.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Inline images are not displayed with MicrosoftGraphApiTransport.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix contentId assignment for inline attachments Fix contentId assignment for inline attachments Oct 29, 2025
@webflo webflo changed the title Fix contentId assignment for inline attachments [Mailer] Fix contentId assignment for inline attachments Oct 29, 2025
@carsonbot carsonbot changed the title [Mailer] Fix contentId assignment for inline attachments Fix contentId assignment for inline attachments Oct 29, 2025
@fabpot
Copy link
Member

fabpot commented Oct 29, 2025

Thank you @webflo.

@fabpot fabpot merged commit e507323 into symfony:7.4 Oct 29, 2025
5 of 12 checks passed
@webflo
Copy link
Contributor Author

webflo commented Oct 29, 2025

@fabpot Thanks for the quick fix. I updated MicrosoftGraphApiTransportTest::testEmbeddedAttachment too. contentId is dynamic. Not sure how to check it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants