[ObjectMapper] lazy loading #62214
Merged
[ObjectMapper] lazy loading #62214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56d8df4 to
3624e4f
Compare
33217e5 to
8ddacb3
Compare
|
|
||
| public function clearObjectMap(): void | ||
| { | ||
| $this->objectMap = null; |
Member
There was a problem hiding this comment.
would replacing the SplObjectStorage by a WeakMap solve this concern?
also: this looks like a reset() method - we might not need a new interface: ResetInterface FTW - if we still need this
src/Symfony/Component/ObjectMapper/Tests/Fixtures/DefaultLazy/OrderSource.php
Outdated
Show resolved
Hide resolved
47f3f59 to
dfb6950
Compare
nicolas-grekas
approved these changes
Nov 4, 2025
soyuka
commented
Nov 4, 2025
| { | ||
| $mapper = new ObjectMapper(); | ||
| $myMapper = new class($mapper) implements ObjectMapperInterface { | ||
| private ?\SplObjectStorage $embededMap = null; |
Contributor
Author
There was a problem hiding this comment.
This test got transformed and now only tests that an embeded relation does call the decorated mapper.
The previous test (based on api-platform/core@d06b1a0) was based on a leaking object map which isn't great (thanks @nicolas-grekas for the fix). The new non-leaky behavior will need an update for our particular use case inside API Platform and that's fine.
Member
|
Thank you @soyuka. |
71c6a60 to
83f086d
Compare
This was referenced Nov 10, 2025
This was referenced Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces lazy loading over the recursive mapping behavior of the ObjectMapper.