[DomCrawler] Handle malformed tags in HTML5 parser #62240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. The updated behavior makes sense. There's no reason a The test should be added to CrawlerTest.php I think, and have proper skips. |
Contributor
Author
|
Ah I didn't see how the tests extended each other before, I understand now. I think this is the right thing to do? The parsers do act differently but I also think it's worth explicitly asserting what each of them do with this edge case, and we might find similar edge cases in the future. |
nicolas-grekas
approved these changes
Oct 31, 2025
991040f to
471acb7
Compare
Member
|
Thank you @longwave. |
This was referenced Nov 2, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DomCrawler to not crash if it encounters a malformed HTML tag; however the behaviour is still different from the previous version if I naively catch and ignore the exception, as demonstrated by the test case; it should pass on PHP 8.3 and fail on 8.4.