🌐 AI搜索 & 代理 主页
Skip to content

[MonologBridge] Accept HttpExceptionInterface in HttpCodeActivationStrategy #62242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Oct 31, 2025
+21 −4
Merged

[MonologBridge] Accept HttpExceptionInterface in HttpCodeActivationStrategy #62242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Bridge/Monolog/Handler/FingersCrossed/HttpCodeActivationStrategy.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use Monolog\Handler\FingersCrossed\ActivationStrategyInterface;
use Monolog\LogRecord;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;

/**
* Activation strategy that ignores certain HTTP codes.
Expand Down Expand Up @@ -49,7 +49,7 @@ public function isHandlerActivated(array|LogRecord $record): bool
if (
$isActivated
&& isset($record['context']['exception'])
&& $record['context']['exception'] instanceof HttpException
&& $record['context']['exception'] instanceof HttpExceptionInterface
&& ($request = $this->requestStack->getMainRequest())
) {
foreach ($this->exclusions as $exclusion) {
Expand Down
21 changes: 19 additions & 2 deletions src/Symfony/Bridge/Monolog/Tests/Handler/FingersCrossed/HttpCodeActivationStrategyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
use Symfony\Bridge\Monolog\Tests\RecordFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpKernel\Exception\HttpException;
use Symfony\Component\HttpKernel\Exception\HttpExceptionInterface;

class HttpCodeActivationStrategyTest extends TestCase
{
Expand Down Expand Up @@ -74,6 +74,23 @@ public static function isActivatedProvider(): array

private static function getContextException(int $code): array
{
return ['exception' => new HttpException($code)];
return ['exception' => new class($code) extends \RuntimeException implements HttpExceptionInterface {
private int $statusCode;

public function __construct(int $statusCode)
{
$this->statusCode = $statusCode;
}

public function getStatusCode(): int
{
return $this->statusCode;
}

public function getHeaders(): array
{
return [];
}
}];
}
}