[Workflow] Fix MethodMarkingStore crash with inherited uninitialized properties
#62458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MethodMarkingStore crash with inherited uninitialized properties
Member
|
Thank you @yoeunes. |
This was referenced Nov 21, 2025
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
MethodMarkingStorewith an uninitialized typed property defined in a parent class,getMarking()crashes.This happens because PHP's internal error message references the declaring class (Parent), but the current code compares it against
get_debug_type($subject)which returns the instance class (Child).This PR relaxes the exception message validation to ignore the class name. It now checks if the message starts with
Typed propertyand ends with the expected uninitialized property suffix.