Add TokenProcessor #8156
Add TokenProcessor #8156
Conversation
javiereguiluz
left a comment
There was a problem hiding this comment.
@maidmaid thanks for this contribution!
We usually explain a new feature and then add the versionadded mentioning when it was added ... but in this case, the versionadded directive tries to explain the feature and show when it was added. I think it's missing some context or explanation.
|
How to do? Add a new |
|
@maidmaid I don't know exactly how to do it. I'm going to think about this, but maybe @xabbuh has some ideas too. An example of what I wanted to explain: https://github.com/symfony/symfony-docs/pull/8146/files In that PR we explain the new feature very briefly and then we say that it's new in Symfony 3.4. |
|
I think the best solution would be to have a paragraph explaining how to enable this processor and then add a |
|
Agreed with @xabbuh. |
|
ping @maidmaid :) |
This PR was merged into the 3.4 branch. Discussion ---------- Adds documentation for monolog processors. Adds both a short description for existing processors as well as a note for the newly added TokenProcessor added in 3.4. I tried not to interfere with #10244 as this introduces documentation for more processors added in 4.3, so that PR hopefully can build on this one. Replaces #8156 EUFOSSA Commits ------- 67f8c2c Adds documentation for monolog processors.
cf symfony/symfony#21086