Narrow t2 selection criteria. #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This narrows the match for things considered to be t2 instances to only those types that start with "t2.". Previously there was a class of (invalid) instance types, such as "2b.something" or "t5.something" that would cause an error on boolean parsing by matching one regex and not the other.
Member
|
This is very neat fix. Thank you for contribution! v1.10.0 has been released. |
Sebor
pushed a commit
to Sebor/terraform-aws-ec2-instance
that referenced
this pull request
Aug 6, 2020
This narrows the match for things considered to be t2 instances to only those types that start with "t2.". Previously there was a class of (invalid) instance types, such as "2b.something" or "t5.something" that would cause an error on boolean parsing by matching one regex and not the other.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This narrows the match for things considered to be t2 instances to only
those types that start with "t2.". Previously there was a class of
(invalid) instance types, such as "2b.something" or "t5.something" that
would cause an error on boolean parsing by matching one regex and not
the other.
This uses conditional logic to identify the non-t2 case, since I don't have a good method for implementing the inverse regular expression without negative lookahead assertions, which re2 doesn't support.