changed the way we store node filenames #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 19, 2016
| return $this->getAttribute('module_filename'); | ||
| $this->filename = $filename; | ||
| foreach ($this->nodes as $node) { | ||
| if (null !== $node) { |
Member
There was a problem hiding this comment.
can it really be null ? This would break the contract
Contributor
Author
There was a problem hiding this comment.
parent is such an example on the main Module node. I agree that this is not great, and probably something I will fix in 2.0.
Contributor
Author
There was a problem hiding this comment.
Actually, there are more than just parent :( I will address that in another PR.
xabbuh
reviewed
Sep 19, 2016
lib/Twig/Node.php
Outdated
| $this->filename = $filename; | ||
| foreach ($this->nodes as $node) { | ||
| if (null !== $node) { | ||
| $node->setFileName($filename); |
Contributor
|
👍 much better solution |
fc1b4ed to
4c4657a
Compare
fabpot
added a commit
that referenced
this pull request
Sep 19, 2016
This PR was merged into the 1.x branch. Discussion ---------- changed the way we store node filenames Commits ------- 4c4657a changed the way we store node filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.