Added RuntimeExtensionInterface #2519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 11, 2017
Contributor
|
rebase needed |
Contributor
Author
|
rebased |
Contributor
|
This PR should be done on the 1.x branch. |
Contributor
|
On 1.x, this means it needs to be an "underscore" class, with namespaced FC layer, isn't it? |
Contributor
Author
|
I'll wait for @fabpot's feedback before updating the PR |
Contributor
|
I have no problem in adding new feature that would be using namespaced class names instead of _ ones. The changelog should just mention that this is restricted to PHP 5.3 only. |
Contributor
Contributor
Author
|
PR updated. Sorry for the delay. |
Contributor
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Aug 16, 2017
This PR was merged into the 1.x branch. Discussion ---------- Added RuntimeExtensionInterface Commits ------- 6f08f57 Added RuntimeExtensionInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.