Added pssibility to reset the profiler #2560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 23, 2017
xabbuh
approved these changes
Sep 24, 2017
Member
|
Does resetting the Profile object actually work fine ? This object is the data object serialized by the TwigDataCollector in |
Contributor
Author
|
@stof This applies to any data collector or tracable service used in Symfony. Because of this, the listener that resets the profiler and other resettable services is triggered very late on the |
Contributor
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2017
This PR was merged into the 1.x branch. Discussion ---------- Added pssibility to reset the profiler In order to implement symfony/symfony#18244 properly, I needed the ability to reset a Twig profile. Commits ------- ea922bb Added pssibility to reset the profiler.
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Oct 5, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][HttpKernel] Reset profiler | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #18244 | License | MIT | Doc PR | N/A This PR adds the ability to reset the profiler between requests. Furthermore, the profiler service has been tagged with the new `kernel.reset` tag from #24155. For this, I had to readd the ability to define multiple reset methods for a service. Note: This PR requires twigphp/Twig#2560. Commits ------- 8c39bf7 Reset profiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to implement symfony/symfony#18244 properly, I needed the ability to reset a Twig profile.