🌐 AI搜索 & 代理 主页
Skip to content

fix(eslint-plugin): [no-deprecated] fix double-report on computed literal identifiers #11006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 17 commits into from
Nov 7, 2025
+744 −53
Merged

fix(eslint-plugin): [no-deprecated] fix double-report on computed literal identifiers #11006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
845839a
fix(eslint-plugin): [no-deprecated] adds support for string literal m…
undsoft Mar 28, 2025
0d81a5b
Merge branch 'main' into 10958-string-literals-in-deprecated
undsoft Mar 31, 2025
82f748f
fix(eslint-plugin): [no-deprecated] adds support for computed member …
undsoft Apr 4, 2025
21ffe65
Merge branch 'main' into 10958-string-literals-in-deprecated
undsoft Apr 4, 2025
4c24c44
Merge branch '10958-string-literals-in-deprecated' of github.com:unds…
undsoft Apr 4, 2025
74c79d9
fix(eslint-plugin): [no-deprecated] adds support for computed member …
undsoft Apr 4, 2025
cb50efe
fix(eslint-plugin): [no-deprecated] adds support for computed member …
undsoft Apr 20, 2025
b749c56
Merge branch 'master' of github.com:undsoft/typescript-eslint into 10…
undsoft Apr 20, 2025
7223496
fix(eslint-plugin): [no-deprecated] adds support for computed member …
undsoft Apr 20, 2025
234e355
Merge branch 'main'
JoshuaKGoldberg Sep 29, 2025
335a66c
Unified branches of logic
JoshuaKGoldberg Sep 29, 2025
c4eb20e
git checkout main -- .vscode/launch.json
JoshuaKGoldberg Sep 29, 2025
61ba88f
Update packages/eslint-plugin/tests/rules/no-deprecated.test.ts
JoshuaKGoldberg Nov 3, 2025
72b1f1d
Remove remaining unnecessary console.logs
JoshuaKGoldberg Nov 3, 2025
3b6fe1f
Literal test for numbers
JoshuaKGoldberg Nov 3, 2025
b5c3371
Retarget to just the computed identifier
JoshuaKGoldberg Nov 3, 2025
f710059
Remove change noise
JoshuaKGoldberg Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/eslint-plugin/src/rules/no-deprecated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,15 @@ export default createRule<Options, MessageIds>({
return;
}

// Computed identifier expressions are handled by checkMemberExpression
if (
parent.type === AST_NODE_TYPES.MemberExpression &&
parent.computed &&
parent.property === node
) {
return;
}

if (parent.type === AST_NODE_TYPES.ExportSpecifier) {
// only deal with the alias (exported) side, not the local binding
if (parent.exported !== node) {
Expand Down
Loading
Loading