🌐 AI搜索 & 代理 主页
Skip to content

fix: normalize tsconfigRootDir to handle trailing path separators in project: true #11419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gingeekrishna wants to merge 5 commits into from
+22 −1
Closed

fix: normalize tsconfigRootDir to handle trailing path separators in project: true #11419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
911890f
fix: normalize tsconfigRootDir to handle trailing path separators in …
gingeekrishna Jul 23, 2025
eefbc4c
refactor: improve fix for trailing path separators
gingeekrishna Jul 23, 2025
0601610
perf: optimize trailing path separator fix
gingeekrishna Jul 24, 2025
24d2d26
style: apply Prettier formatting
gingeekrishna Jul 24, 2025
702596c
ci: trigger fresh CI run to resolve AtomicsWaitError infrastructure i…
gingeekrishna Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/typescript-estree/src/parseSettings/getProjectConfigFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ export function getProjectConfigFiles(
let directory = path.dirname(parseSettings.filePath);
const checkedDirectories = [directory];

// Normalize tsconfigRootDir once to avoid repeated regex operations in the loop
const normalizedTsconfigRootDirLength = Math.max(
1,
parseSettings.tsconfigRootDir.replace(/[/\\]+$/, '').length,
);

do {
log('Checking tsconfig.json path: %s', directory);
const tsconfigPath = path.join(directory, 'tsconfig.json');
Expand All @@ -57,7 +63,7 @@ export function getProjectConfigFiles(
checkedDirectories.push(directory);
} while (
directory.length > 1 &&
directory.length >= parseSettings.tsconfigRootDir.length
directory.length >= normalizedTsconfigRootDirLength
);

throw new Error(
Expand Down
15 changes: 15 additions & 0 deletions packages/typescript-estree/tests/lib/getProjectConfigFiles.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,5 +178,20 @@ describe(getProjectConfigFiles, () => {
`[Error: project was set to \`true\` but couldn't find any tsconfig.json relative to './repos/repo/packages/package/file.ts' within '/'.]`,
);
});

it('works correctly with trailing path separator in tsconfigRootDir', () => {
mockExistsSync.mockImplementation(
filePath => filePath === path.normalize('repos/repo/tsconfig.json'),
);

const actual = getProjectConfigFiles(
{ ...parseSettings, tsconfigRootDir: './repos/repo/' },
true,
);

expect(actual).toStrictEqual([
path.normalize('repos/repo/tsconfig.json'),
]);
});
});
});
Loading