🌐 AI搜索 & 代理 主页
Skip to content

fix(eslint-plugin): [consistent-type-exports] fix declaration shadowing #11457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 6 commits into from
Sep 5, 2025
Merged

fix(eslint-plugin): [consistent-type-exports] fix declaration shadowing #11457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9155df0
fix type shadowing
ntdiary Aug 5, 2025
ed89a6f
Merge branch 'main' into fix-declaration-shadowing
ntdiary Aug 5, 2025
5e05413
Merge branch 'main' into fix-declaration-shadowing
ntdiary Aug 15, 2025
4218a02
Merge branch 'main' into fix-declaration-shadowing
ntdiary Aug 20, 2025
99627c4
Merge branch 'main' into fix-declaration-shadowing
ntdiary Aug 31, 2025
0a88ead
Merge branch 'main' into fix-declaration-shadowing
ntdiary Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions packages/eslint-plugin/src/rules/consistent-type-exports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { TSESLint, TSESTree } from '@typescript-eslint/utils';

import { AST_NODE_TYPES, AST_TOKEN_TYPES } from '@typescript-eslint/utils';
import * as tsutils from 'ts-api-utils';
import * as ts from 'typescript';

import {
Expand Down Expand Up @@ -91,22 +90,18 @@ export default createRule<Options, MessageIds>({
function isSymbolTypeBased(
symbol: ts.Symbol | undefined,
): boolean | undefined {
if (!symbol) {
return undefined;
while (symbol && symbol.flags & ts.SymbolFlags.Alias) {
symbol = checker.getAliasedSymbol(symbol);
if (
symbol.getDeclarations()?.find(ts.isTypeOnlyImportOrExportDeclaration)
) {
return true;
}
}

const aliasedSymbol = tsutils.isSymbolFlagSet(
symbol,
ts.SymbolFlags.Alias,
)
? checker.getAliasedSymbol(symbol)
: symbol;

if (checker.isUnknownSymbol(aliasedSymbol)) {
if (!symbol || checker.isUnknownSymbol(symbol)) {
return undefined;
}

return !(aliasedSymbol.flags & ts.SymbolFlags.Value);
return !(symbol.flags & ts.SymbolFlags.Value);
}

return {
Expand Down
26 changes: 26 additions & 0 deletions packages/eslint-plugin/tests/rules/consistent-type-exports.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ export { NonTypeNS };
"export type * as foo from './consistent-type-exports/type-only-exports';",
"export type * as foo from './consistent-type-exports/type-only-reexport';",
"export * as foo from './consistent-type-exports/value-reexport';",
`
import * as Foo from './consistent-type-exports';
type Foo = 1;
export { Foo }
`,
],
invalid: [
{
Expand Down Expand Up @@ -483,5 +488,26 @@ export {
export type * as foo from './consistent-type-exports/type-only-reexport';
`,
},
{
code: `
import type * as Foo from './consistent-type-exports';
type Foo = 1;
export { Foo };
`,
errors: [
{
column: 9,
endColumn: 24,
endLine: 4,
line: 4,
messageId: 'typeOverValue',
},
],
output: `
import type * as Foo from './consistent-type-exports';
type Foo = 1;
export type { Foo };
`,
},
],
});
Loading