🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@Zamiell
Copy link
Contributor

@Zamiell Zamiell commented Aug 10, 2025

PR Checklist

Overview

Semi colons were being used incorrectly.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 10, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit d4443b3
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68c7552a604fa40008bd15aa
😎 Deploy Preview https://deploy-preview-11471--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 4 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 10, 2025

View your CI Pipeline Execution ↗ for commit d4443b3

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 2s View ↗
nx run-many -t lint ✅ Succeeded 3m 13s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 9s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 7s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-15 00:04:36 UTC

@Zamiell Zamiell changed the title grammar fix: grammar Aug 10, 2025
@Zamiell Zamiell changed the title fix: grammar fix(utils): grammar Aug 10, 2025
@Zamiell Zamiell marked this pull request as ready for review August 10, 2025 15:48
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Aug 20, 2025
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (fee2bc6) to head (d4443b3).
⚠️ Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11471      +/-   ##
==========================================
+ Coverage   90.87%   90.90%   +0.02%     
==========================================
  Files         505      505              
  Lines       51117    51197      +80     
  Branches     8415     8441      +26     
==========================================
+ Hits        46455    46540      +85     
+ Misses       4648     4644       -4     
+ Partials       14       13       -1     
Flag Coverage Δ
unittest 90.90% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/utils/src/ts-eslint/eslint/FlatESLint.ts 100.00% <ø> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Josh-Cena Josh-Cena added 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting response Issues waiting for a reply from the OP or another party labels Sep 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix(utils): grammar docs(utils): grammar Sep 15, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit c58ac35 into typescript-eslint:main Sep 15, 2025
66 of 67 checks passed
@Zamiell Zamiell deleted the grammar branch September 15, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants