🌐 AI搜索 & 代理 主页
Skip to content

docs: add parserOptions note to Type Checking #11523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 9 commits into from
Sep 29, 2025
Merged

docs: add parserOptions note to Type Checking #11523

JoshuaKGoldberg merged 9 commits into from
Sep 29, 2025

Conversation

@thebolarin
Copy link
Contributor

@thebolarin thebolarin commented Aug 22, 2025

PR Checklist

Overview

The “Projects With Type Checking” docs were updated to include the missing languageOptions.parserOptions in both Flat and Legacy Config examples. This ensures type-checking works correctly and links users to the Typed Linting guide for more details.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Aug 22, 2025

Thanks for the PR, @thebolarin!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 22, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1f8ff23
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68da914a4ffc54000854a6ba
😎 Deploy Preview https://deploy-preview-11523--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 1f8ff23

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 6s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 56s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-29 14:09:00 UTC

@codecov
Copy link

codecov bot commented Sep 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.93%. Comparing base (9fd1cc6) to head (1f8ff23).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11523   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51370    51394   +24     
  Branches     8476     8482    +6     
=======================================
+ Hits        46711    46735   +24     
  Misses       4646     4646           
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thebolarin
Copy link
Contributor Author

thebolarin commented Sep 1, 2025

@JoshuaKGoldberg Could you please take a look at this PR when you have a chance? Thanks!

Josh-Cena
Josh-Cena requested changes Sep 2, 2025
View reviewed changes
@thebolarin
Copy link
Contributor Author

thebolarin commented Sep 2, 2025

@Josh-Cena Thank you for the review. I've added the requested changes. Kindly review when you have a chance. Thanks

@thebolarin
Copy link
Contributor Author

thebolarin commented Sep 29, 2025

Hello @JoshuaKGoldberg Please can i get a review on this PR. Thank you

Josh-Cena
Josh-Cena reviewed Sep 29, 2025
View reviewed changes
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9aebdaf into typescript-eslint:main Sep 29, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Josh-Cena requested changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs: "Projects With Type Checking" missing parserOptions

3 participants

@thebolarin @JoshuaKGoldberg @Josh-Cena