🌐 AI搜索 & 代理 主页
Skip to content

chore(typescript-estree): add Converter#convertChildren() #11592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 4 commits into from
Sep 22, 2025
Merged

chore(typescript-estree): add Converter#convertChildren() #11592

JoshuaKGoldberg merged 4 commits into from
Sep 22, 2025

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Sep 10, 2025

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 10, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 10, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit eae0bed
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68cbee5b6cc2e10007e9b764
😎 Deploy Preview https://deploy-preview-11592--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 72 (🔴 down 15 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit eae0bed

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 7s View ↗
nx run-many -t lint ✅ Succeeded 3m 10s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 1s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 22s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-18 11:47:15 UTC

@fisker fisker changed the title refactor(typescript-estree): add Converter#covertChildren() chore(typescript-estree): add Converter#covertChildren() Sep 10, 2025
@fisker fisker marked this pull request as ready for review September 10, 2025 23:31
@codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 53.19149% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.93%. Comparing base (2f0c6ac) to head (eae0bed).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 53.19% 22 Missing ⚠️

❌ Your patch status has failed because the patch coverage (53.19%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11592   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51332    51323    -9     
  Branches     8473     8461   -12     
=======================================
- Hits        46677    46672    -5     
+ Misses       4642     4638    -4     
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <53.19%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.28% <53.19%> (-0.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -3 net line change is a nice touch 🙂 +1 from me.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 15, 2025
kirkwaiblinger
kirkwaiblinger reviewed Sep 16, 2025
View reviewed changes
kirkwaiblinger
kirkwaiblinger reviewed Sep 16, 2025
View reviewed changes
kirkwaiblinger
kirkwaiblinger requested changes Sep 16, 2025
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor touchups requested

@JoshuaKGoldberg JoshuaKGoldberg removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 16, 2025
@fisker
Merge branch 'main' into convert-children
eae0bed 
# Conflicts:
#	packages/typescript-estree/src/convert.ts
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 20, 2025
@kirkwaiblinger kirkwaiblinger changed the title chore(typescript-estree): add Converter#covertChildren() chore(typescript-estree): add Converter#convertChildren() Sep 20, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 328a96d into typescript-eslint:main Sep 22, 2025
65 of 66 checks passed
@fisker fisker deleted the convert-children branch September 22, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fisker @JoshuaKGoldberg @kirkwaiblinger