-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(typescript-estree): simplify convertImportAttributes
#11594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(typescript-estree): simplify convertImportAttributes
#11594
Conversation
|
Thanks for the PR, @fisker! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 03acd62
☁️ Nx Cloud last updated this comment at |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #11594 +/- ##
=======================================
Coverage 90.92% 90.93%
=======================================
Files 506 506
Lines 51338 51332 -6
Branches 8473 8473
=======================================
- Hits 46678 46677 -1
+ Misses 4647 4642 -5
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| const attritbutes = node.attributes ?? node.assertClause; | ||
| return ( | ||
| attritbutes?.elements.map(element => this.convertChild(element)) ?? [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const attritbutes = node.attributes ?? node.assertClause; | |
| return ( | |
| attritbutes?.elements.map(element => this.convertChild(element)) ?? [] | |
| const attributes = node.attributes ?? node.assertClause; | |
| return ( | |
| attributes?.elements.map(element => this.convertChild(element)) ?? [] |
b1eb30f

PR Checklist
Overview