🌐 AI搜索 & 代理 主页
Skip to content

chore: slightly improve convertComments #11632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 1 commit into from
Sep 29, 2025
Merged

chore: slightly improve convertComments #11632

JoshuaKGoldberg merged 1 commit into from
Sep 29, 2025

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Sep 25, 2025 •
edited
Loading

PR Checklist

Overview

The textEnd is actually the length of the value text of the comment, but textEnd is what we needed.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Sep 25, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Sep 25, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2a4387b
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68d57583d7b0f1000866159c
😎 Deploy Preview https://deploy-preview-11632--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Sep 25, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2a4387b

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 8s View ↗
nx run-many -t lint ✅ Succeeded 3m 12s View ↗
nx run-many -t typecheck ✅ Succeeded 2m View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 20s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 11s View ↗
nx run integration-tests:test ✅ Succeeded 6s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-09-25 17:13:52 UTC

@codecov
Copy link

codecov bot commented Sep 25, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.93%. Comparing base (9fd1cc6) to head (2a4387b).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert-comments.ts 0.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11632   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         506      506           
  Lines       51370    51370           
  Branches     8476     8476           
=======================================
  Hits        46711    46711           
  Misses       4646     4646           
  Partials       13       13
Flag Coverage Δ
unittest 90.93% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert-comments.ts 47.05% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 29, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice!

@JoshuaKGoldberg JoshuaKGoldberg merged commit eb57a3e into typescript-eslint:main Sep 29, 2025
64 of 66 checks passed
@fisker fisker deleted the convertComments branch September 29, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @JoshuaKGoldberg