-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Revert "feat(eslint-plugin): expose rule name via RuleModule interface" #11663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(eslint-plugin): expose rule name via RuleModule interface" #11663
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit c80d100
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember the details, but I remember previously nx was super picky about the PR title for a revert PR, so might be worth double checking that before merging
|
This is a breaking change, no? Now fails to typecheck with v8.46.0+. |
|
It was added in one version and immediately removed in the next version because it introduced bugs. From our POV that is NOT a breaking change - it should not have landed at all. |
|
@jfirebaugh FWIW we were intending to do an immediate patch release to revert it, but ran into CI/automation issues, so it ended up just going out as part of the next regularly-scheduled minor, rather than its own patch. |
|
I see... I guess we upgraded at exactly the wrong time, such that we had to add |

Reverts #11616
I'd like to get the change back in, but it's non-trivial to work around #11662.
Fixes #11662.