🌐 AI搜索 & 代理 主页
Skip to content

chore: refactor createError for easier use #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 3 commits into from
Nov 26, 2025
Merged

chore: refactor createError for easier use #11775

JoshuaKGoldberg merged 3 commits into from
Nov 26, 2025
+53 −43

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Nov 23, 2025 •
edited
Loading

PR Checklist

Overview

Move

typescript-eslint/packages/typescript-estree/src/convert.ts

Lines 169 to 178 in c421d30

let start;
let end;
if (Array.isArray(node)) {
[start, end] = node;
} else if (typeof node === 'number') {
start = end = node;
} else {
start = node.getStart(this.ast);
end = node.getEnd();
}
part to createError, so other places can pass numer | Range too.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Nov 23, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 23, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 763e7fb
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/69229981a966cc00083a395e
😎 Deploy Preview https://deploy-preview-11775--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 763e7fb

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 16s View ↗
nx run-many -t lint ✅ Succeeded 3m 15s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 13s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 10s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-11-23 05:31:36 UTC

@codecov
Copy link

codecov bot commented Nov 23, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 36.95652% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.56%. Comparing base (c421d30) to head (763e7fb).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/check-modifiers.ts 0.00% 24 Missing ⚠️
packages/typescript-estree/src/node-utils.ts 75.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (36.95%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11775      +/-   ##
==========================================
- Coverage   90.57%   90.56%   -0.01%     
==========================================
  Files         522      522              
  Lines       53079    53082       +3     
  Branches     8842     8844       +2     
==========================================
+ Hits        48074    48076       +2     
- Misses       4989     4991       +2     
+ Partials       16       15       -1
Flag Coverage Δ
unittest 90.56% <36.95%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 30.97% <100.00%> (-0.10%) ⬇️
packages/typescript-estree/src/node-utils.ts 70.27% <75.00%> (-0.21%) ⬇️
packages/typescript-estree/src/check-modifiers.ts 15.92% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fisker fisker marked this pull request as ready for review November 23, 2025 07:56
@fisker fisker mentioned this pull request Nov 23, 2025
Open
3 tasks
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy either way 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 24, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 9738933 into typescript-eslint:main Nov 26, 2025
66 of 67 checks passed
@fisker fisker deleted the createError branch November 26, 2025 17:40
@fisker fisker mentioned this pull request Nov 26, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @JoshuaKGoldberg