🌐 AI搜索 & 代理 主页
Skip to content

fix(eslint-plugin): [no-unused-private-class-members] private destructured class member is defined but used #11785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuyaYoshioka wants to merge 6 commits into
base: main
Choose a base branch
from
+148 −1
Open

fix(eslint-plugin): [no-unused-private-class-members] private destructured class member is defined but used #11785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b95b746
fix private destructed class member case
YuyaYoshioka Nov 24, 2025
f7c6afe
remove destructuredThisProperties
YuyaYoshioka Nov 24, 2025
c5c4417
handle AssignmentExpression and AssignmentPattern
YuyaYoshioka Nov 24, 2025
2c1598e
Merge branch 'main' into issue-11771
YuyaYoshioka Nov 24, 2025
aa962d3
Merge branch 'main' into issue-11771
YuyaYoshioka Nov 27, 2025
83c15c3
add test
YuyaYoshioka Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion packages/eslint-plugin/src/util/class-scope-analyzer/classScopeAnalyzer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
extractNameForMember,
extractNameForMemberExpression,
} from './extractComputedName';
import { privateKey } from './types';
import { privateKey, publicKey } from './types';

export class Member {
/**
Expand Down Expand Up @@ -435,6 +435,28 @@ abstract class ThisScope extends Visitor {
// Visit selectors //
/////////////////////

protected AssignmentExpression(node: TSESTree.AssignmentExpression): void {
this.visitChildren(node);

if (
node.right.type === AST_NODE_TYPES.ThisExpression &&
node.left.type === AST_NODE_TYPES.ObjectPattern
) {
this.handleThisDestructuring(node.left);
}
}

protected AssignmentPattern(node: TSESTree.AssignmentPattern): void {
this.visitChildren(node);

if (
node.right.type === AST_NODE_TYPES.ThisExpression &&
node.left.type === AST_NODE_TYPES.ObjectPattern
) {
this.handleThisDestructuring(node.left);
}
}

protected ClassDeclaration(node: TSESTree.ClassDeclaration): void {
this.visitClass(node);
}
Expand Down Expand Up @@ -528,6 +550,49 @@ abstract class ThisScope extends Visitor {
protected StaticBlock(node: TSESTree.StaticBlock): void {
this.visitIntermediate(node);
}

protected VariableDeclarator(node: TSESTree.VariableDeclarator): void {
this.visitChildren(node);

if (
node.init?.type === AST_NODE_TYPES.ThisExpression &&
node.id.type === AST_NODE_TYPES.ObjectPattern
) {
this.handleThisDestructuring(node.id);
}
}

/**
* Handles destructuring from `this` in ObjectPattern.
* Example: const { property } = this;
*/
private handleThisDestructuring(pattern: TSESTree.ObjectPattern): void {
if (this.thisContext == null) {
return;
}

for (const prop of pattern.properties) {
if (prop.type !== AST_NODE_TYPES.Property) {
continue;
}

if (prop.key.type !== AST_NODE_TYPES.Identifier) {
continue;
}

const memberKey = publicKey(prop.key.name);
const members = this.isStaticThisContext
? this.thisContext.members.static
: this.thisContext.members.instance;
const member = members.get(memberKey);

if (member == null) {
continue;
}

countReference(prop.key, member);
}
}
}

/**
Expand Down
82 changes: 82 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unused-private-class-members.test.ts
View file
Open in desktop
Copy link
Member

@kirkwaiblinger kirkwaiblinger Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(testing)

Please also include a few tests around the long form destructuring assignment, i.e.

class Foo {
  private privateMember;

  method() {
    const { unused: privateNember } = this;
  }
}
class Foo {
  private privateMember;

  method() {
    const { privateNember: used } = this;
  }
}

Copy link
Contributor Author

@YuyaYoshioka YuyaYoshioka Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I fixed at 83c15c3

Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,70 @@ class C {
}
}
`,
`
class Foo {
private privateMember;
private privateMember2;

method() {
const { privateMember, privateMember2 } = this;
console.log(privateMember, privateMember2);
}
}
`,
`
class Foo {
private static staticMember = 1;
static method() {
const { staticMember } = this;
console.log(staticMember);
}
}
`,
`
class Foo {
private privateMember = 1;
method() {
const { privateMember } = this;
}
}
`,
`
class Foo {
private privateMember = 1;
method() {
const { privateMember: privateMember2 } = this;
}
}
`,
`
class Foo {
private privateMember = 1;

method() {
let privateMember;
({ privateMember } = this);
}
}
`,
`
class Foo {
private privateMember = 1;

method() {
const foo = ({ privateMember } = this) => {};
}
}
`,
`
class Foo {
private privateMember;

method() {
const { privateMember: used } = this;
}
}
`,
//--------------------------------------------------------------------------
// Method definitions
//--------------------------------------------------------------------------
Expand Down Expand Up @@ -1217,6 +1280,25 @@ class Foo {
method() {
[this.privateMember] = bar;
}
}
`,
errors: [
{
data: {
classMemberName: 'privateMember',
},
messageId: 'unusedPrivateClassMember',
},
],
},
{
code: `
class Foo {
private privateMember;

method() {
const { unused: privateMember } = this;
}
}
`,
errors: [
Expand Down
Loading