🌐 AI搜索 & 代理 主页
Skip to content

feat: support passing "mode" to organize imports command #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rchl merged 3 commits into from
Oct 31, 2025
Merged

feat: support passing "mode" to organize imports command #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b2c113
feat: support passing "mode" to organize imports command
rchl Oct 31, 2025
b37054b
update code
rchl Oct 31, 2025
b321767
update code
rchl Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,16 @@ Request:
{
command: '_typescript.organizeImports'
arguments: [
// The "skipDestructiveCodeActions" argument is supported from Typescript 4.4+
[string] | [string, { skipDestructiveCodeActions?: boolean }],
string, // file URI
// Optional options:
{
// @deprecated - use "mode". Supported from Typescript 4.4+.
skipDestructiveCodeActions?: boolean
// 'All' - organizes imports including destructive actions (removing unused imports)
// 'SortAndCombine' - Doesn't perform destructive actions.
// 'RemoveUnused' - Only removes unused imports.
mode?: 'All' | 'SortAndCombine' | 'RemoveUnused'
},
]
}
```
Expand Down
5 changes: 3 additions & 2 deletions src/lsp-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,9 +903,10 @@ export class LspServer {
return;
}

const additionalArguments = (params.arguments[1] || {}) as { skipDestructiveCodeActions?: boolean; };
const additionalArguments = (params.arguments[1] || {}) as { skipDestructiveCodeActions?: boolean; mode?: OrganizeImportsMode; };
const body = await this.tsClient.interruptGetErr(async () => {
await this.fileConfigurationManager.ensureConfigurationForDocument(document);
const mode = additionalArguments.mode ?? (additionalArguments.skipDestructiveCodeActions ? OrganizeImportsMode.SortAndCombine : OrganizeImportsMode.All);
const response = await this.tsClient.execute(
CommandTypes.OrganizeImports,
{
Expand All @@ -915,7 +916,7 @@ export class LspServer {
},
// Deprecated in 4.9; `mode` takes priority
skipDestructiveCodeActions: additionalArguments.skipDestructiveCodeActions,
mode: additionalArguments.skipDestructiveCodeActions ? OrganizeImportsMode.SortAndCombine : OrganizeImportsMode.All,
mode,
},
token,
);
Expand Down