🌐 AI搜索 & 代理 主页
Skip to content

Fix Jsp versioning #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josh-hadley merged 2 commits into from
Jun 14, 2023
Merged

Fix Jsp versioning #499

josh-hadley merged 2 commits into from
Jun 14, 2023

Conversation

@josh-hadley
Copy link
Collaborator

@josh-hadley josh-hadley commented Jun 13, 2023

Per discussion in unicodetools meeting 13 June 2023:

  • "The beta version string should just use Settings.latestVersion" — updated UnicodeJsp.java to use Settings.latestVersion
  • "The jspVersionInfo should use UCharacter.getUnicodeVersion() to match what it serves — as long as it serves ICU property values" — reworked CachedProps.java to use UCharacter.getInstance for jspVersionInfo

@josh-hadley
Fix Jsp versioning
508c927 
Per discussion in unicodetools meeting 13 June 2023:
- "The beta version string should just use Settings.latestVersion" — updated UnicodeJsp.java to use Settings.latestVersion
- "The jspVersionInfo should use UCharacter.getUnicodeVersion() to match what it serves — as long as it serves ICU property values" — reworked CachedProps.java to use UCharacter.getInstance for jspVersionInfo
@josh-hadley
Update CachedProps.java
4a9b3d3 
missing import
markusicu
markusicu approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

@josh-hadley josh-hadley marked this pull request as ready for review June 13, 2023 21:05
@josh-hadley josh-hadley merged commit cf7b302 into main Jun 14, 2023
@josh-hadley josh-hadley deleted the jh-fix-jsp-versioning branch June 14, 2023 16:02
@josh-hadley
Copy link
Collaborator Author

josh-hadley commented Jun 14, 2023 •
edited
Loading

@srl295 @markusicu I will make made a new release with this update. Once it builds Can one of you deploy/promote it to production so the fix is live on util.unicode.org?

@markusicu
Copy link
Member

markusicu commented Jun 14, 2023

I made a new release with this update. Can one of you deploy/promote it to production so the fix is live on util.unicode.org?

I will give it a try...

@markusicu
Copy link
Member

markusicu commented Jun 14, 2023

Deployed!

Properties use ICU for Unicode V15.0; the beta properties support Unicode V15.1β.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srl295 srl295 srl295 approved these changes

@macchiati macchiati macchiati approved these changes

@markusicu markusicu markusicu approved these changes

@echeran echeran Awaiting requested review from echeran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@josh-hadley @markusicu @srl295 @macchiati