🌐 AI搜索 & 代理 主页
Skip to content

feat: enable @typescript-eslint/recommended in create-next-app --typescript #52845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eps1lon merged 17 commits into from
Jun 27, 2024
Merged

feat: enable @typescript-eslint/recommended in create-next-app --typescript #52845

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aab603d
feat: use @typescript-eslint/recommended-type-checked in create-next-…
JoshuaKGoldberg Jul 20, 2023
6097634
Remove missing link
JoshuaKGoldberg Jul 27, 2023
be44617
Switch to next/typescript
JoshuaKGoldberg Jul 27, 2023
f2197eb
lil docs typo
JoshuaKGoldberg Jul 27, 2023
2e0ae5f
Undid js config file updates
JoshuaKGoldberg Jul 27, 2023
aa44c6a
Reduced eslint-plugin to ^6.0.0
JoshuaKGoldberg Jul 27, 2023
3aee1e9
Fix next-lint.test.js integration test
JoshuaKGoldberg Jul 28, 2023
856b45d
Small refactor: extracted getESLintStrictValue
JoshuaKGoldberg Oct 31, 2023
34b0b3d
Pass basedir/cwd through
JoshuaKGoldberg Oct 31, 2023
6fb50cf
There was a floating Promise. Amusing
JoshuaKGoldberg Oct 31, 2023
258aba9
Switch to recommended, not recommended-type-checked
JoshuaKGoldberg Jun 3, 2024
4bc8cbd
fix: touchups to eslint-config-next
JoshuaKGoldberg Jun 18, 2024
74b9541
Update tests
eps1lon Jun 25, 2024
ee438b8
Corrections: non-TS starter .json; pass cwd to findUp
JoshuaKGoldberg Jun 25, 2024
141b92d
test: next-lint.test.js
JoshuaKGoldberg Jun 25, 2024
7c99396
Avoid mistakes by writing simple code
eps1lon Jun 26, 2024
726f533
Restore and align previous dependency version
eps1lon Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid mistakes by writing simple code
  • Loading branch information
@eps1lon
eps1lon committed Jun 26, 2024
commit 7c9939695dd2cf92405409564739efbcf6b9a1db
3 changes: 2 additions & 1 deletion packages/next/src/lib/eslint/getESLintPromptValues.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import findUp from 'next/dist/compiled/find-up'

export const getESLintStrictValue = async (cwd: string) => {
const hasTSConfig = !!(await findUp('tsconfig.json', { cwd }))
const tsConfigLocation = await findUp('tsconfig.json', { cwd })
const hasTSConfig = tsConfigLocation !== undefined

return {
title: 'Strict',
Expand Down