🌐 AI搜索 & 代理 主页
Skip to content

Conversation

@kalu5
Copy link
Contributor

@kalu5 kalu5 commented Nov 14, 2025

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

resolve #5001

Additional context

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. directive labels Nov 14, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025

Open in StackBlitz

@vueuse/components

npm i https://pkg.pr.new/@vueuse/components@5166

@vueuse/core

npm i https://pkg.pr.new/@vueuse/core@5166

@vueuse/electron

npm i https://pkg.pr.new/@vueuse/electron@5166

@vueuse/firebase

npm i https://pkg.pr.new/@vueuse/firebase@5166

@vueuse/integrations

npm i https://pkg.pr.new/@vueuse/integrations@5166

@vueuse/math

npm i https://pkg.pr.new/@vueuse/math@5166

@vueuse/metadata

npm i https://pkg.pr.new/@vueuse/metadata@5166

@vueuse/nuxt

npm i https://pkg.pr.new/@vueuse/nuxt@5166

@vueuse/router

npm i https://pkg.pr.new/@vueuse/router@5166

@vueuse/rxjs

npm i https://pkg.pr.new/@vueuse/rxjs@5166

@vueuse/shared

npm i https://pkg.pr.new/@vueuse/shared@5166

commit: 5d2c90a

},
unmounted(el) {
vElementHoverScopes.get(el)?.stop()
vElementHoverScopes.delete(el)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could create an intentional factory function to generate the directive with mount/unmount hooks that have a more friendly way to register the clean up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, too

I think it can be like this. What do you think

creatFunc :

function createDirectiveHooks(
  cleanupOnUnmount = false,
  options?: {
    mountedCallback?: (el: HTMLElement, binding: DirectiveBinding) => void
    unmountedCallback?: (el: HTMLElement) => void
  },
) {
  const isFunc = (fn: unknown) => {
    return typeof fn === 'function'
  }
  const { mountedCallback, unmountedCallback } = options ?? {}

  const vDirectiveScopes = new WeakMap<HTMLElement, EffectScope>()

  return {
    mounted(el: HTMLElement, binding: DirectiveBinding) {
      if (!cleanupOnUnmount) {
        if (isFunc(mountedCallback))
          mountedCallback(el, binding)
        return
      }
      const scope = vDirectiveScopes.get(el) ?? effectScope()
      vDirectiveScopes.set(el, scope)
      scope.run(() => {
        if (isFunc(mountedCallback))
          mountedCallback(el, binding)
      })
    },
    unmounted(el: HTMLElement) {
      if (cleanupOnUnmount) {
        vDirectiveScopes.get(el)?.stop()
        vDirectiveScopes.delete(el)
      }

      if (isFunc(unmountedCallback))
        unmountedCallback(el)
    },
  }
}

use:

export const vElementHover: ObjectDirective<
  HTMLElement,
  BindingValueFunction | [handler: BindingValueFunction, options: UseElementHoverOptions]
> = {
  // mounted(el, binding) {
  //   const scope = vElementHoverScopes.get(el) ?? effectScope()
  //   vElementHoverScopes.set(el, scope)
  //   scope.run(() => {
  //     const value = binding.value
  //     if (typeof value === 'function') {
  //       const isHovered = useElementHover(el)
  //       watch(isHovered, v => value(v))
  //     }
  //     else {
  //       const [handler, options] = value
  //       const isHovered = useElementHover(el, options)
  //       watch(isHovered, v => handler(v))
  //     }
  //   })
  // },
  // unmounted(el) {
  //   vElementHoverScopes.get(el)?.stop()
  //   vElementHoverScopes.delete(el)
  // },
  ...createDirectiveHooks(
    true,
    {
      mountedCallback: (el, binding) => {
        const value = binding.value
        if (typeof value === 'function') {
          const isHovered = useElementHover(el)
          watch(isHovered, v => value(v))
        }
        else {
          const [handler, options] = value
          const isHovered = useElementHover(el, options)
          watch(isHovered, v => handler(v))
        }
      },
    },
  ),
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had this idea before, but considering that all the modifications would turn into one submission

@antfu antfu added the direction: approved The direction of feature/change is approved by the team. May require some small changes. label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction: approved The direction of feature/change is approved by the team. May require some small changes. directive size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG | Directives aren't cleaned up when component unmounts

2 participants