fix(useMagicKeys): KeyboardEvent with .key == undefined throws an error. #5205
+25
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autocomplete in chromium can trigger a KeyboardEvent where the
keyproperty is undefined (as suggested here: https://issues.chromium.org/issues/40539270 and here: microsoft/TypeScript#59631).In this case, (useMagicKeys/index.ts:122) throws an error:
Additional context
Line :139 (in
updateRefs) already suggests that an undefined value is actually anticipated:Fixed existing test
While fixing this, I also noticed that the test 'should handle empty key events without errors' probably does not work as intended:
expect().not.toThrowThis is fixed in this PR as well.