Expose an API to write lock the database #1558
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1558 +/- ##
==========================================
- Coverage 99.44% 99.38% -0.07%
==========================================
Files 58 58
Lines 11317 11327 +10
==========================================
+ Hits 11254 11257 +3
- Misses 63 70 +7 ☔ View full report in Codecov by Sentry. |
Contributor
|
is there a risk that on bellows implementation, we come to a Timeout because the backup will last more than 5 seconds ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Home Assistant backups to be safe, we should write lock the database during
pre_backupand unlock it duringpost_backup. This will effectively queue all zigpy database writes for many minutes but we don't rely on the database to hold data at runtime, just to act as a store.home-assistant/core#138544